Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLOUDP-292365: Support Flex Clusters #2030

Merged
merged 35 commits into from
Jan 23, 2025
Merged

CLOUDP-292365: Support Flex Clusters #2030

merged 35 commits into from
Jan 23, 2025

Conversation

roothorp
Copy link
Collaborator

@roothorp roothorp commented Jan 9, 2025

All Submissions:

  • Have you signed our CLA?
  • Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if there is one).
  • Update docs/release-notes/release-notes-template.md if your changes should be included in the release notes for the next release.

@roothorp
Copy link
Collaborator Author

roothorp commented Jan 9, 2025

Currently failing tests (need to change some more tests to use SdkClientSet), and needs rebasing once I'm done with that, but hopefully gives an insight.

josvazg
josvazg reviewed Jan 9, 2025
View reviewed changes
test/helper/contract/ako.go Outdated Show resolved Hide resolved
josvazg
josvazg reviewed Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@josvazg josvazg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM so far, not approving yet as ti is still draft.

I really liked the way you sliced it into separate commits, easier to focus on reviewing each of them!

@roothorp roothorp marked this pull request as ready for review January 16, 2025 13:47
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 16, 2025 •
edited
Loading

https://app.codecov.io/github/mongodb/mongodb-atlas-kubernetes/commit/e6e9d1d664d31c6fec0017139b9856e3e4d93d9d

@roothorp roothorp merged commit 802db8c into main Jan 23, 2025
58 checks passed
@roothorp roothorp deleted the cloudp-292365-flex branch January 23, 2025 14:20
JuliaMongo
JuliaMongo reviewed Jan 30, 2025
View reviewed changes
api/v1/atlasdeployment_types.go
Comment on lines +548 to +563

// List that contains key-value pairs between 1 to 255 characters in length for tagging and categorizing the instance.
// +kubebuilder:validation:MaxItems=50
// +optional
Tags []*TagSpec `json:"tags,omitempty"`

// Flag that indicates whether termination protection is enabled on the cluster.
// If set to true, MongoDB Cloud won't delete the cluster. If set to false, MongoDB Cloud will delete the cluster.
// +kubebuilder:default:=false
// +optional
TerminationProtectionEnabled bool `json:"terminationProtectionEnabled,omitempty"`

// Group of cloud provider settings that configure the provisioned MongoDB flex cluster.
// +required
ProviderSettings *FlexProviderSettings `json:"providerSettings"`
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JuliaMongo JuliaMongo JuliaMongo left review comments

@s-urbaniak s-urbaniak s-urbaniak left review comments

@josvazg josvazg josvazg approved these changes

@helderjs helderjs helderjs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@roothorp @helderjs @s-urbaniak @josvazg @JuliaMongo